Skip to content

Add legacy activity-alias for web-ext support #1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 6, 2020

Conversation

jonalmeida
Copy link
Collaborator

Related web-ext PR: mozilla/web-ext#1871

Pull Request checklist

Before merging checklist

  • Changelog: This PR includes a changelog entry or does not need one.

@jonalmeida jonalmeida requested a review from a team as a code owner March 27, 2020 16:25
@jonalmeida
Copy link
Collaborator Author

In mozilla-mobile/fenix#9462, I thought we could remove the ${applicationId} but it looks like our tooling requires it to work this way.

@Rob--W
Copy link

Rob--W commented Mar 27, 2020

This change is not required by web-ext, see mozilla/web-ext#1871 (comment)

@Amejia481 Amejia481 self-assigned this Mar 30, 2020
@Amejia481 Amejia481 self-requested a review March 30, 2020 17:46
@Amejia481 Amejia481 added the 🕵️‍♀️ needs review PRs that need to be reviewed label Mar 30, 2020
@jonalmeida jonalmeida added 🛑 blocked Issues that are blocked by external causes. and removed 🛑 blocked Issues that are blocked by external causes. labels Mar 30, 2020
@Amejia481 Amejia481 merged commit e589de2 into mozilla-mobile:master Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕵️‍♀️ needs review PRs that need to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants