Skip to content

balrog shouldn't serve update xml that is invalid #3119

@bhearsum

Description

@bhearsum

In https://bugzilla.mozilla.org/show_bug.cgi?id=1893487 we had an issue that resulted in us serving update xml such as:

<?xml version="1.0"?>
<updates>
    <update type="minor" displayVersion="125.0a1" appVersion="125.0a1" platformVersion="125.0a1" buildID="20240301094944">
    </update>
</updates>

This is not valid, because it doesn't contain any patch entries, and Firefox was unable to parse it. (There are probably other ways the xml can be invalid as well, this is just one example.)

In cases like this we should probably throw a 500, and ensure that an Exception ends up in Sentry for visibility.

@bytesized - cc'ing you for visibility, and also in case you are aware of any existing schemas or validation code we have for these responses.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions