Skip to content

Drop Python 3.6, use 3.8 instead #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2019
Merged

Drop Python 3.6, use 3.8 instead #54

merged 1 commit into from
Nov 6, 2019

Conversation

rail
Copy link
Contributor

@rail rail commented Nov 6, 2019

No description provided.

@rail rail self-assigned this Nov 6, 2019
@escapewindow
Copy link
Contributor

escapewindow commented Nov 6, 2019 •
edited
Loading

We may want to run our unit tests on py38 before we run it in production :)

Ah, you're adding 3.8, but running on 3.7. n/m :)

@rail
Copy link
Contributor Author

rail commented Nov 6, 2019

Time to rebase

@rail rail requested a review from escapewindow November 6, 2019 05:35
@MihaiTabara
Copy link
Contributor

\o/

escapewindow
escapewindow approved these changes Nov 6, 2019
View reviewed changes
Copy link
Contributor

@escapewindow escapewindow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add the py37 and py38 support strings into setup.py, but that might not be necessary since we're not pushing these to pypi.

Looks good, 🚢
Thanks!

@rail rail merged commit b3d441d into mozilla-releng:master Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escapewindow escapewindow escapewindow approved these changes

Assignees

@rail rail

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rail @escapewindow @MihaiTabara