adds new action in action map for creating a shipit release #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
functions that should probably become methods in shipitapi: |
MihaiTabara
reviewed
Nov 18, 2019
| @@ -66,3 +66,7 @@ def check_release_has_values_v2(release_api, release_name, headers, **kwargs): | |||
| raise ScriptWorkerTaskException(err_msg) | |||
|
|
|||
| log.info("All release fields have been correctly updated in Ship-it!") | |||
|
|
|||
|
|
|||
| def get_buildnum_from_version(next_version): | |||
There was a problem hiding this comment.
We might be able to consume this from mozilla-version.
MihaiTabara
approved these changes
Nov 18, 2019
allan-silva
pushed a commit
to allan-silva/scriptworker-scripts
that referenced
this pull request
Nov 19, 2019
…releng#75) * adds new action in action map for creating a shipit release * Fix tox by importing functions properly * use shipitapi for interfacing with shipit * fix create_new_release_action typo * Add triggering phase logic * fixes up tox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.