Skip to content

Add Memory64 post #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 15, 2025
Merged

Conversation

bvisness
Copy link
Contributor

No description provided.

@mgaudet mgaudet self-requested a review January 14, 2025 22:48
Copy link
Contributor

@mgaudet mgaudet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me!

Copy link

@eqrion eqrion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

One meta comment here, it would be really nice if we could quantify 'slow' somehow.

Here's several things I found online:
WebAssembly/memory64#3 (comment)
WebAssembly/memory64#3 (comment)
https://x.com/ThaLobsta/status/1332814463418810369

I also know that V8 now implements a hybrid signal-handling + bounds check scheme that gave them good results. https://groups.google.com/g/v8-reviews/c/VdlZacHKm_4
Basically do a bounds check to see if high bits are set (which requires no loading of a memory bound), then rely on a 16GiB of mapped pages.

The overall gist is still correct and worth sharing, it'd just be nice to just give them some data so they can make the informed choice.

@bvisness
Copy link
Contributor Author

Thanks for the feedback - I'll do a round of updates tomorrow and then maybe we can publish later in the day or Thursday.

@bvisness
Copy link
Contributor Author

I'm ready to go when you all are.

@mgaudet mgaudet merged commit 7c5c3da into mozilla-spidermonkey:production Jan 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants