Skip to content

send enforcement action for override decisions #23710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eviljeff
Copy link
Member

@eviljeff eviljeff commented Jul 18, 2025

Fixes: mozilla/addons#15371

Description

Trivial change to now send enforcement action too for an override decision, with some clean-up because now all decision endpoints accept the same action and policies fields.

Testing

Pretty trivial change, but to test:

  • set your setting CINDER_SERVER_URL to https://mozilla-staging.cinderapp.com/api/v1/ (until update CINDER_SERVER_URL to saas cinder #23709 is merged)
  • in reviewer tools force disable a recommended add-on
  • in 2nd level approval queue in reviewer tools, requeue the add-on in the reviewer tools
  • back in reviewer tools, resolve the (newly created, from requeue) job, but this time reject the a version instead of disable
  • check in fake mail for the email to the developer about the rejection
  • check in Cinder that the override decision has the enforcement action of amo-reject-version-addon rather than amo-disable-addon.

Checklist

  • Add #ISSUENUM at the top of your PR to an existing open issue in the mozilla/addons repository.
  • Successfully verified the change locally.
  • The change is covered by automated tests, or otherwise indicated why doing so is unnecessary/impossible.

@eviljeff eviljeff force-pushed the 15371-send-enforcement-action-for-decision-override branch from 2a1fcaa to a420e4c Compare July 21, 2025 09:13
@eviljeff eviljeff force-pushed the 15371-send-enforcement-action-for-decision-override branch from a420e4c to bef54c6 Compare July 21, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Send enforcement action to cinder for decision override
1 participant