Make sure _health_check.yml can run on fork PRs by only attempting a slack notification if the channel is defined. #23716
+20
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinMind
force-pushed
the
kevinmind/addons/15736
branch
2 times, most recently
from
d6a298e to
34b1a7f
Compare
…s defined (it is not defined on forks which now causes PRs to break CI)
KevinMind
force-pushed
the
kevinmind/addons/15736
branch
from
34b1a7f to
0fbdb27
Compare
KevinMind
changed the title
3 tasks
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the health check workflow to work with fork PRs by making Slack notifications conditional on having a defined channel. The changes prevent fork PRs from failing due to missing Slack channel variables while maintaining notification functionality for the main repository.
Key changes:
- Added a
slack_channelparameter to the health check workflow - Made Slack notifications conditional on channel availability
- Updated notification conditions to exclude fork PRs
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/_health_check.yml |
Added slack_channel input parameter and conditional Slack notification logic |
.github/workflows/health_check.yml |
Passed SLACK_ADDONS_PRODUCTION_CHANNEL variable to health check workflow |
.github/workflows/ci.yml |
Added slack_channel parameter and fork detection for notification exclusion |
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/mozilla/addons/ISSUENUM
Description
Context
Testing
Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.