[Bug]: override decision call from Cinder returns a 200, not a 201, so we raise instead of accepting it.

[eviljeff]

What happened?

Cinder sends a 200 for a successful decision override (it sends a 201 for a create decision, and a decision on a job). Anything after that override call (e.g. emails) won't be sent.

What did you expect to happen?

Not raise an exception

Is there an existing issue for this?

• I have searched the existing issues

┆Issue is synchronized with this Jira Task

[ioanarusiczki]

On AMO dev:

• I disabled from Cinder/rev tools 2nd level approval extensions
• resolved with approve

Email is sent to reporter

Process button not greyed out
https://reviewers.addons-dev.allizom.org/en-US/reviewers/decision-review/6947
https://reviewers.addons-dev.allizom.org/en-US/reviewers/decision-review/6957

at a new attempt would throw a 500, I'll file a followup.

I've also tested
proceed and forward to rev tools. Worked as expected and "proceed" is greyed out in these cases.

Approve with https://reviewers.addons-dev.allizom.org/en-US/reviewers/review/636070
Proceed with https://reviewers.addons-dev.allizom.org/en-US/reviewers/review/636071
Forward to rev tools with https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-listed/636072

[ioanarusiczki]

Tested on stage with https://reviewers.addons.allizom.org/en-US/reviewers/review-listed/2245625

Email is sent