Bug 2022743: Use 'async' for NimbusInterface.recordEventOrThrow [ci full]#7267
Open
moztcampbell wants to merge 1 commit intomozilla:mainfrom
Open
Bug 2022743: Use 'async' for NimbusInterface.recordEventOrThrow [ci full]#7267moztcampbell wants to merge 1 commit intomozilla:mainfrom
moztcampbell wants to merge 1 commit intomozilla:mainfrom
Conversation
In order to actually propegate the errors to the caller, we need to run the coroutine with 'async' instead of 'launch'.
Collaborator
Author
|
I did manual testing with Fenix by adding a use of this API, and modifying the underlying recordEvent to throw an exception. I was able to confirm that changing 'launch' to 'async' turns exception into a catchable one as desired. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to actually propegate the errors to the caller, we need to run the coroutine with 'async' instead of 'launch'.
https://kotlinlang.org/docs/exception-handling.html#exception-propagation
Pull Request checklist
[ci full]to the PR title.recordEventfailures with current interface.