Skip to content

Add a couple of dummy mozilla-central crates to assist with the monor…#7269

Open
mhammond wants to merge 1 commit intomozilla:mainfrom
mhammond:push-uxlwokvtzywo
Open

Add a couple of dummy mozilla-central crates to assist with the monor…#7269
mhammond wants to merge 1 commit intomozilla:mainfrom
mhammond:push-uxlwokvtzywo

Conversation

@mhammond
Copy link
Member

…epo migration.

These allow app-services to be built in mozilla-central without modification.

  • A mozilla-central-workspace-hack crate, because top-level crates built in m-c need to have a reference to a crate of this name.

  • A mozbuild crate to help building with ohttp in mozilla-central. For this to be effective it will need a new ohttp release which changes the "app-svc" feature to auto-detect when it is in this repo or in mozilla-central, so this dummy creates enough of a stub to keep the compiler happy.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@mhammond
Copy link
Member Author

See also martinthomson/ohttp#94, cc @moztcampbell

@mhammond mhammond force-pushed the push-uxlwokvtzywo branch from 8a70ca6 to 8199cfb Compare March 13, 2026 05:33
@mhammond
Copy link
Member Author

While not strictly needed for this PR, Martin already merged that PR, so I might as well add the use of it here.

…epo migration.

These allow app-services to be built in mozilla-central without modification.

* A `mozilla-central-workspace-hack` crate, because top-level crates built
 in m-c need to have a reference to a crate of this name.

* A `mozbuild` crate to help building with ohttp in mozilla-central.
  For this to be effective it will need a new ohttp release which
  changes the "app-svc" feature to auto-detect when it is in this
  repo or in mozilla-central, so this dummy creates enough of
  a stub to keep the compiler happy.
@mhammond mhammond force-pushed the push-uxlwokvtzywo branch from 8199cfb to 5cb16fb Compare March 13, 2026 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants