Skip to content

chore(schema): apply base schema imports for telemetry_derived#9598

Merged
chelseyklein merged 194 commits into
mainfrom
auto/schema-descriptions-telemetry_derived-20260617-194310
Jun 23, 2026
Merged

chore(schema): apply base schema imports for telemetry_derived#9598
chelseyklein merged 194 commits into
mainfrom
auto/schema-descriptions-telemetry_derived-20260617-194310

Conversation

@chelseyklein

@chelseyklein chelseyklein commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Base Schema Imports

Generated using the schema enricher agent

Jira: DENG-11210

Applied !include-field-description tags to 185 table schemas in telemetry_derived, referencing sql/moz-fx-data-shared-prod/telemetry_derived/telemetry_derived.yaml.

Base schema fields: 917

Applied from telemetry_derived.yaml

…s_daily_agg_by_default_browser_lifecycle_stage_v1
Comment thread sql/moz-fx-data-shared-prod/telemetry_derived/telemetry_derived.yaml Outdated
…d.yaml

Co-authored-by: Lucia <30448600+lucia-vargas-a@users.noreply.github.com>
@scholtzan

Copy link
Copy Markdown
Collaborator

Integration report

@chelseyklein

chelseyklein commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

@sean-rose quick question, wouldn't this be equivalent to add a single include of the telemetry dataset schema at the top of the file? And add individual descriptions only for those we want to overwrite.

i hope this is the case - that simplifies things :)

though, i'm confused about how this would work on nested columns where the structure is defined in the schema.yaml - i think because of this we don't want to integrate this logic at scale right now. it would mean adding another decision tree to the agent with additional logic where if there are no nested values, import full file...if there are nested values, generate this other way. that's not something we planned for and would further delay this project. there's a lot more logic we could add...but we are deciding not to in order to get this done...else we'd be adding logic indefinitely

@scholtzan

Copy link
Copy Markdown
Collaborator

Integration report

Comment thread sql/moz-fx-data-shared-prod/telemetry_derived/telemetry_derived.yaml Outdated
Comment thread sql/moz-fx-data-shared-prod/telemetry_derived/telemetry_derived.yaml Outdated
Comment thread sql/moz-fx-data-shared-prod/telemetry_derived/telemetry_derived.yaml Outdated

@lucia-vargas-a lucia-vargas-a left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest reviewing the description for dau given its importance - Alsowau and mau for precision and docs.

chelseyklein and others added 4 commits June 23, 2026 09:06
…d.yaml

Co-authored-by: Lucia <30448600+lucia-vargas-a@users.noreply.github.com>
…d.yaml

Co-authored-by: Lucia <30448600+lucia-vargas-a@users.noreply.github.com>
…d.yaml

Co-authored-by: Lucia <30448600+lucia-vargas-a@users.noreply.github.com>
@scholtzan

Copy link
Copy Markdown
Collaborator

Integration report

@scholtzan

Copy link
Copy Markdown
Collaborator

Integration report

@scholtzan

Copy link
Copy Markdown
Collaborator

Integration report

@scholtzan

Copy link
Copy Markdown
Collaborator

Integration report

@chelseyklein chelseyklein enabled auto-merge June 23, 2026 16:22
@chelseyklein chelseyklein added this pull request to the merge queue Jun 23, 2026
@scholtzan

Copy link
Copy Markdown
Collaborator

Integration report

Merged via the queue into main with commit b098639 Jun 23, 2026
26 checks passed
@chelseyklein chelseyklein deleted the auto/schema-descriptions-telemetry_derived-20260617-194310 branch June 23, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants