Skip to content

Do not verify the ssl cert when connecting securely to redis. #1762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marco-c merged 1 commit into from
Mar 1, 2023
Merged

Do not verify the ssl cert when connecting securely to redis. #1762

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion backend/code_coverage_backend/gcp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,14 @@ class GCPCache(object):

def __init__(self, reports_dir=None):
# Open redis connection
self.redis = redis.from_url(taskcluster.secrets["REDIS_URL"])
redis_url = taskcluster.secrets["REDIS_URL"]
# Are we dealing with a redis ssl/tls connection?
if redis_url.startswith("rediss:"):
# The cert is self signed so do not check it
self.redis = redis.from_url(redis_url, ssl_cert_reqs="none")
else:
# No we are not, we are connecting transparently
self.redis = redis.from_url(redis_url)
assert self.redis.ping(), "Redis server does not ping back"

# Open gcp connection to bucket
Expand Down