Skip to content

Do not use pulse messages from non gecko builds #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 23, 2019
Merged

Do not use pulse messages from non gecko builds #182

merged 2 commits into from
Sep 23, 2019

Conversation

La0
Copy link
Contributor

@La0 La0 commented Sep 23, 2019

Fixes #180

@La0 La0 added the events Event listener label Sep 23, 2019
@La0 La0 requested a review from marco-c September 23, 2019 10:28
@La0 La0 self-assigned this Sep 23, 2019
marco-c
marco-c reviewed Sep 23, 2019
View reviewed changes
events/code_coverage_events/workflow.py Outdated
group_id=taskGroupId,
scheduler=scheduler,
)
return
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: explicitly return None like the other cases where we return early

@La0 La0 merged commit dcac151 into mozilla:master Sep 23, 2019
@La0 La0 deleted the fix-180 branch September 23, 2019 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-c marco-c marco-c approved these changes

Assignees

@La0 La0

Labels
events Event listener
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Directly skip messages whose routingKey/schedulerId is not linked to mozilla-central or try
2 participants
@La0 @marco-c