Skip to content

frontend: Sort the coverage reports by ascending order #190 #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

GGeethanjali
Copy link
Contributor

This commit addresses the issue reported in #190

Sort the coverage reports by ascending order

@La0 La0 self-requested a review October 29, 2019 09:15
@La0 La0 added the frontend Javascript Frontend label Oct 29, 2019
Copy link
Contributor

@La0 La0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sort logic seems OK, but that's not the goal of the issue (sorry the issue #190 was not clear enough, i updated it).

The goal is to add clickable buttons on the coverage percent column header to be able to sort by coverage percent.
The data is currently sorted by name, so that column header should also become clickable to allow the user to get back to the initial state.

Here is an example table with sort columns

@GGeethanjali
Copy link
Contributor Author

Okay will look into it

@La0
Copy link
Contributor

La0 commented Nov 7, 2019

@GGeethanjali We are in the process of upgrading our CI system: Could you please rebase and update your pull request ?

Did you get time to add the sorting capability to the frontend ? Thanks !

@marco-c
Copy link
Collaborator

marco-c commented Nov 14, 2019

Closing for lack of response, but feel free to reopen if you still intend to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Javascript Frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants