Skip to content

Issue #97, add explanation box - 2nd PR #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 11, 2020
Merged

Issue #97, add explanation box - 2nd PR #454

merged 5 commits into from
Mar 11, 2020

Conversation

InfTkm
Copy link
Contributor

@InfTkm InfTkm commented Mar 8, 2020

Fixed #97 and deleted trailing white spaces according to Taskcluster's log.

https://youtu.be/xmY6yLb7gu4
Here is a demo. Hopefully, I understood correctly where the question mark box should be.

Explanation of what I have done:

Line 59 in zero_coverage_report.js: sets the variable needs_explanation to true for the filter, completely_uncovered.
Line 138 - 146 in base.html: add the tooltip if the filter needs explanation (i.e. completely_uncovered).
At the end of style.scss: I added the CSS for the tooltip (i.e. popup explanation box) using SASS format.
Let me know if you have any questions or feedback. Thanks.

@InfTkm
Copy link
Contributor Author

InfTkm commented Mar 8, 2020

I didn't know that I could update the commits in a PR without creating a new one. Sorry about the duplicated PR.

@marco-c marco-c requested a review from La0 March 9, 2020 11:31
Copy link
Contributor

@La0 La0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work !

@marco-c I'm ok with the display code, even though the style is a bit overkill, it looks nice.
We could reduce the explanation text as it's simply a copypasta from an IRC discussion right now. WDYT ?

@La0
Copy link
Contributor

La0 commented Mar 10, 2020

And here is a link to the frontend from this build so you can test.

@marco-c
Copy link
Collaborator

marco-c commented Mar 10, 2020

Yes, definitely better to rewrite that:

For JavaScript, files with at least one function where all functions are uncovered. For C/C++/other languages, files which have no covered lines.

@La0
Copy link
Contributor

La0 commented Mar 10, 2020

@InfTkm Could you update the explanation text with the one mentionned above by Marco ?

@InfTkm
Copy link
Contributor Author

InfTkm commented Mar 10, 2020

@La0 Hi, the change is made, and you can see the result here.
Thanks.

Copy link
Contributor

@La0 La0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this great contribution 👍

@La0 La0 merged commit 2966037 into mozilla:master Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explain heuristics used for "uncovered files" in the UI
3 participants