Skip to content

Match the style of the logo with the menu #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 30, 2020
Merged

Match the style of the logo with the menu #489

merged 6 commits into from
Apr 30, 2020

Conversation

Crystal-RainSlide
Copy link
Contributor

@Crystal-RainSlide Crystal-RainSlide commented Apr 7, 2020

See issue #488 for the details of this PR, and pull #504 for another change preposed in the issue.

@marco-c
Copy link
Collaborator

marco-c commented Apr 19, 2020

I agree with the logo change, but why making the file list so narrow?

P.S.: Could you split the PR in two?

@Crystal-RainSlide
Copy link
Contributor Author

why making the file list so narrow?

To not to make the space between the file list so wide, so I shrink it into a size that is wider than phone screens.

Will widen the file list; and you are all free to edit my PR.


Maybe the best way is to put something else along with it, but, the history graph is horizontal, and nothing else left on the index page.

@marco-c
Copy link
Collaborator

marco-c commented Apr 27, 2020

OK, could you split the PR in two? I'd like to have separate logical changes :)

@Crystal-RainSlide
Copy link
Contributor Author

Crystal-RainSlide commented Apr 28, 2020

Fine~

And done.

@Crystal-RainSlide Crystal-RainSlide changed the title Match the style of the logo with the menu, and redo the width & margin of #browser Match the style of the logo with the menu Apr 28, 2020
Copy link
Collaborator

@marco-c marco-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@marco-c marco-c merged commit a1218c6 into mozilla:master Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Match the style of the logo with the menu, and redo the width & margin of #browser
2 participants