Issue #668 - Changes for using json-automationrelevance instead of json-rev

[shubham-y]

Fixes #668

[marco-c]

@shubham-y did you test the function like I described at #668 (comment)? Is it returning the same result before/after your change?

Note: there are some tests that need to be adjusted, you can look at the test logs by clicking on "Details" on the right of "Community-TC" and then opening the failing Code Coverage Backend checks: unit tests task and then clicking on "View Live Log".

[shubham-y]

@marco-c yes, the function is returning the same result before and after my change.
I did look at test logs as you mentioned but struggling to find a way to pass that test.

[marco-c]

Did you manage to run the test locally?

[marco-c]

Here's the test that is failing:

code-coverage/backend/tests/test_gcp.py

Line 168 in 6dfbd06

def test_closest_report(mock_cache, mock_hgmo):

.

It is failing because the code it is testing is trying to load https://hg.mozilla.org/myrepo/json-automationrelevance/9921e08232584198aab1c015f3ea8b78, but we have not registered it as a mock response for the test.

The test def test_closest_report(mock_cache, mock_hgmo) is using mock_cache and mock_hgmo. mock_hgmo is the one you need to modify to fix the problem, it is registering the mock responses:

code-coverage/backend/tests/conftest.py

Line 138 in 6dfbd06

def mock_hgmo():

.
In particular, it is registering a response for json-rev (

code-coverage/backend/tests/conftest.py

Line 188 in 6dfbd06

re.compile("https://hg.mozilla.org/(.+)/json-rev/(.+)"),

), you need to change it to register a response for json-automationrelevance instead.

[shubham-y]

@marco-c I have finally managed to run the test locally and made a few changes in mock_hgmo as pointed out by you.
After changes now I am facing a <ExceptionInfo KeyError('changesets',) tblen=3> exception.

[marco-c]

@marco-c I have finally managed to run the test locally and made a few changes in mock_hgmo as pointed out by you.
After changes now I am facing a <ExceptionInfo KeyError('changesets',) tblen=3> exception.

This means the mock response you added doesn't have a changesets key, that you are using in the code at https://github.com/mozilla/code-coverage/pull/927/files#diff-6f7fa9ada2bb8845e9f5b8b0e5932694e9e465825627142e760f0df43b7a31e7R34.
You should make sure the mock response is the same you get when you hit the actual json-automationrelevance API.

If you can't figure it out, please push your changes so I can see them in the PR, otherwise I can't help you further.

[marco-c]

@shubham-y are you still interested in working on this?

[shubham-y]

@marco-c Yes, I am still interested to work on this.
I will be working on this issue this week and try and push some changes by this weekend.

[shubham-y]

@marco-c I have finally managed to run the test locally and made a few changes in mock_hgmo as pointed out by you.
After changes now I am facing a <ExceptionInfo KeyError('changesets',) tblen=3> exception.

This means the mock response you added doesn't have a changesets key, that you are using in the code at https://github.com/mozilla/code-coverage/pull/927/files#diff-6f7fa9ada2bb8845e9f5b8b0e5932694e9e465825627142e760f0df43b7a31e7R34.
You should make sure the mock response is the same you get when you hit the actual json-automationrelevance API.

If you can't figure it out, please push your changes so I can see them in the PR, otherwise I can't help you further.

@marco-c I have pushed my changes, can you please help me further?

[marco-c]

Could you rebase on top of current master?

[marco-c]

Looks good, thanks!