Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ jobs:
- name: Build package for upload to PyPI
run: python -m build .
- name: Upload the distribution to PyPI
uses: pypa/gh-action-pypi-publish@v1.4.2
uses: pypa/gh-action-pypi-publish@v1.13.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last time I tried anything newer than 1.4.2 was not allowed in @mozilla org:/

It errors out in this startup failure: https://github.com/mozilla/django-product-details/actions/runs/18003443633

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a syntax allowlisted that should work for @release/* but I couldn't get that one to work either:/

I know Rob requested both and confirmed that working https://bugzilla.mozilla.org/show_bug.cgi?id=1842108 but something must have changed in the rule order/inheritance since:/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah see the ticket now: https://bugzilla.mozilla.org/show_bug.cgi?id=1990779 — thanks! This has been confusing and obnoxious, glad the wildcard is there now for every org. 💟 🚀

with:
user: __token__
password: ${{ secrets.PYPI_API_TOKEN }}