mercurial: take into account more cases of mercurial failures for retry. #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marco-c
reviewed
Jun 2, 2023
abpostelnicu
force-pushed
the
stream_ended
branch
from
f2b372d to
9b640cc
Compare
abpostelnicu
force-pushed
the
stream_ended
branch
from
9b640cc to
29e8235
Compare
marco-c
reviewed
Jun 2, 2023
Co-authored-by: Marco Castelluccio <[email protected]>
marco-c
reviewed
Jun 2, 2023
Comment on lines
+465
to
+468
| for eligible_message in eligible_errors: | ||
| if eligible_message in error_log: | ||
| return True | ||
| return False |
There was a problem hiding this comment.
Nit: you could simplify this with:
return any(eligible_message in error_log for eligible_message in eligible_errors)
marco-c
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.