[DENG-10517] Dedupe same name metrics for real this time#320
Merged
Conversation
BenWu
force-pushed
the
benwu/fix-duped-metrics-2
branch
from
d48b71a to
3a87671
Compare
BenWu
force-pushed
the
benwu/fix-duped-metrics-2
branch
from
3a87671 to
a0bca2f
Compare
wwyc
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://mozilla-hub.atlassian.net/browse/DENG-10517
#318 didn't fully fix the issue because metrics can have different names but normalize to the same name for the bigquery column. I think the non-deterministic slection happens in the jsonschema-transpiler around here
https://github.com/mozilla/jsonschema-transpiler/blob/7be6bea2d89fb4491b1a331a39a2d7a0c9010b2f/src/ast.rs#L393.
The fix here is to dedupe on the normalized name