Conditionally bundle gulp image_decoders-specific code in src/core/jbig2.js (PR 9729 follow-up)
#14994
Conversation
…/jbig2.js` (PR 9729 follow-up) This method/function was added only for the `gulp image_decoders`-builds, and is completely unused elsewhere (e.g. in the Firefox PDF Viewer). While this only reduces the size of the *built* `pdf.worker.js` file by a little over 1 kB, it can't hurt to remove completely unused code from the "normal" builds.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/4d8a2956e143f11/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/31ed3f696f26abb/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/4d8a2956e143f11/output.txt Total script time: 26.44 mins
Image differences available at: http://54.241.84.105:8877/4d8a2956e143f11/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/31ed3f696f26abb/output.txt Total script time: 28.42 mins
|
|
Unrelated to this patch, but from time to time I see this test |
I believe that it's a fairly recent intermittent failure, affecting only Firefox on Linux, and I thus suspect that https://bugzilla.mozilla.org/show_bug.cgi?id=1770088 is the culprit. |
|
Thanks! |
This method/function was added only for the
gulp image_decoders-builds, and is completely unused elsewhere (e.g. in the Firefox PDF Viewer).While this only reduces the size of the built
pdf.worker.jsfile by a little over 1 kB, it can't hurt to remove completely unused code from the "normal" builds.