Skip to content

Add an additional CI system #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Luni-4
Copy link
Collaborator

@Luni-4 Luni-4 commented Mar 14, 2020

In order to test rust-code-analysis on different operating systems, I've added GitHub Actions.

Thanks in advance for your review! :)

@Luni-4 Luni-4 changed the title Add an additional CI Add an additional CI system Mar 14, 2020
@marco-c
Copy link
Collaborator

marco-c commented Mar 14, 2020

Unfortunately I think we can't use GitHub Actions in the mozilla GitHub org for the time being (https://bugzilla.mozilla.org/show_bug.cgi?id=1594423).
We can probably support testing on other operating systems via Taskcluster, I will figure out how.

@Luni-4
Copy link
Collaborator Author

Luni-4 commented Mar 15, 2020

Oh, I see. If we can use Taskcluster to test the code on other operating systems, it would be fine for me.

@marco-c
Copy link
Collaborator

marco-c commented Mar 16, 2020

@Luni-4
Copy link
Collaborator Author

Luni-4 commented Mar 16, 2020

It should be possible to use Windows after mozilla/community-tc-config#238, here's an example: https://github.com/taskcluster/taskcluster-worker-runner/blob/2ebe797d89f3dd3c814ea4f881a2a5c6306653db/.taskcluster.yml#L76-L113.

Good, thanks! Is Visual Studio already installed? Because if it's not, it will be difficult to install that every time

@marco-c
Copy link
Collaborator

marco-c commented Mar 16, 2020

I think we have all we need, this is the setup script: https://raw.githubusercontent.com/taskcluster/generic-worker/2509a1f8589b0b536186f5fe8f043385bf67197f/worker_types/win2012r2/bootstrap.ps1. It is also used to create the image needed to build Firefox, so a lot of things are already available.

@Luni-4
Copy link
Collaborator Author

Luni-4 commented Mar 16, 2020

Perfect!

@marco-c
Let me know when the TaskCluster solution will be ready :)

@marco-c
Copy link
Collaborator

marco-c commented Mar 16, 2020

taskcluster/community-tc-config#238 has been merged, we should now be able to use it.

@Luni-4
Copy link
Collaborator Author

Luni-4 commented Mar 17, 2020

mozilla/community-tc-config#238 has been merged, we should now be able to use it.

Great! So are you working on that @marco-c ?

@Luni-4 Luni-4 requested a review from calixteman March 17, 2020 15:46
@marco-c
Copy link
Collaborator

marco-c commented Mar 19, 2020

Great! So are you working on that @marco-c ?

I started a WIP PR just to show the skeleton, not sure when I'll be able to continue it though.
Feel free to take it over if you want.

I'm closing this since we can't use GitHub Actions, feel free to open a new one if you want to take #122 over.

@marco-c marco-c closed this Mar 19, 2020
@Luni-4
Copy link
Collaborator Author

Luni-4 commented Mar 19, 2020

Perfect! Thanks a lot, @marco-c, I will try to update your PR then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants