Avoid undefined line in fromStringWithSourceMap #288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid calling substr on `undefined` in `fromStringWithSourceMap`. This can happen when passing in a source map that refers to lines past the end of the passed-in string -- caller error, but let's not die. Fixes mozilla#247
This was referenced Sep 27, 2017
Closed
|
Self-approving because it's the same as a different patch that I would have ok'd had it not had a merge conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid calling substr on
undefinedinfromStringWithSourceMap.This can happen when passing in a source map that refers to lines past
the end of the passed-in string -- caller error, but let's not die.
Fixes #247