Skip to content

fixing devision by 0 and improving cache call #1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

zassoulin
Copy link

fixxed issue where incase of whitespace file name devision by 0 would occuer see issue #1313.
now when a file name is whitespace no text would be rendered.
also it may be better to use .get() instead of try/catch in ttfonts as try/catch are usualy not ideal.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just an opinion and I will ignore this.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a valid fix and I will implement this.

@mozman
Copy link
Owner

mozman commented Jul 6, 2025

Thank you!

@mozman mozman closed this Jul 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants