Skip to content
This repository was archived by the owner on Jun 29, 2023. It is now read-only.

Conversation

Batigoal
Copy link
Contributor

My changes/addons should be useful for your project:

  • GelfRedisSender was not threadsafe. Now uses a JedisPool. The configuration of GelfRedisSender was also buggy
  • For flexible plugin of other Sender-implementations I've refactored the GelfSenderFactory to be more flexible by the use of the Java ServiceLoader. Now you can plugin or replace new senders by an implementation of RedisGelfSenderProvider and configure them in any META-INF/services in the classpath
    -> First effect of this refactoring: You don't need to explicit define the Test-Gelfsender in all your tests/TestLoggers. Instead of this, it's now configured under META-INF/services

Batigoal added 4 commits May 15, 2014 16:01
outside the core project (including tests)

Refactored/Fixed GelfREDISSender for use in multihreaded environment
@mp911de
Copy link
Owner

mp911de commented May 21, 2014

Great work! Thanks a lot.

mp911de added a commit that referenced this pull request May 21, 2014
Redis bugfix and GelfSender flexibility
@mp911de mp911de merged commit 8b883df into mp911de:master May 21, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants