Skip to content

Ghc 8.8.1 support #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

Avi-D-coder
Copy link

  1. I figured demoting redundant imports to a warning was better then continuing to add unnecessary CPP all over the place. Let me know If I should revert this.

  2. A 8.8 compatible apply-refact needs to be to hackage, so we can get rid of the submodule.

@fendor
Copy link
Collaborator

fendor commented Dec 18, 2019

This is great! Thank you a lot!
Regarding the warnings, I do not feel too strongly about it, but I would prefer if the warning is only disabled in files where it is necessary.

Since CI is missing for Ghc 8.8.1 support, I would also prefer it, if this PR would land after hie-bios is merged into master.

@lukel97
Copy link
Collaborator

lukel97 commented Dec 20, 2019

ping @mpickering for apply-refact hackage release?

@Avi-D-coder
Copy link
Author

Moving to haskell#1482

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants