Fix: Use fixed 0x01 for COMMAND INFO per Tian-Power BMS protocol 2.2.3 #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks! |
mr-manuel
pushed a commit
that referenced
this pull request
Jul 17, 2025
cgoudie
pushed a commit
to TechBlueprints/venus-os_dbus-serialbattery
that referenced
this pull request
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the command frame sent to Tian-Power BMS devices for telemetry retrieval.
According to the official Tian-Power Communication Protocol v2.2.3 , section 5.1 (Table 5), the COMMAND INFO field (i.e., the fifth byte after CID2) is fixed to 0x01 for requesting real-time telemetry. It should not be derived from the device address or any external logic.
Reference:
“At this time, the specific COMMAND GROUP is fixed to 01H, indicating that the first group of battery telemetry data is acquired.”
This fix ensures protocol compliance and improves compatibility with Tian-Power BMS units.