Jk bms pb sn fix #355
Merged
Jk bms pb sn fix #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
December 9, 2025 01:48
Owner
|
Thanks! |
mr-manuel
reviewed
Dec 9, 2025
|
|
||
| ODDRunTime = unpack_from("<I", status_data, 38)[0] # 1 unit32 # runtime of the system in seconds | ||
| PWROnTimes = unpack_from("<I", status_data, 42)[0] # 1 unit32 # how many startups the system has done | ||
| serial_nr = status_data[46:61].decode("utf-8").split("\x00", 1)[0] # serialnumber 16 chars max |
Owner
There was a problem hiding this comment.
May it be, that the protocol differs from hardware version to hardware version? I cannot believe, that this data is provided twice.
Contributor
Author
There was a problem hiding this comment.
serialnumber is provided two times in the memory.
I have tested it with Hardware Version 15 and 19.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add an fix for JKBMS_PB driver to read the full serial number from modbus.
Also additional information like SoH, Heating, the Usr and Usr2 information fields and some other available parameters.
Fixes #354