fix(filtering): dist-newstile typo #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Review ChecklistDoes this PR follow the Contribution Guidelines? Following is a partial checklist: Proper conventional commit scoping:
If applicable:
|
mrcjkb
changed the title
Owner
|
@all-contributors please add @tilin94 for bug |
Contributor
|
I've put up a pull request to add @tilin94! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #271
The dist-newstyle/ directory is not being filtered out during test discovery. This causes
neotest-haskell to pick up autogenerated files like:
dist-newstyle/build/.../autogen/Paths_.hs
dist-newstyle/build/.../autogen/PackageInfo_.hs
When select_framework runs on these files, it fails with "Could not find a test framework handler"
since they don't import any test framework. This error cascades through nio.gather() and results in: