Skip to content

Blender Exporter: Fixed rotation for scene export #12987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

BenCidPerez
Copy link
Contributor

Use correct rotation for static meshes when exporting scenes.

This has been a problem for a while now (See #12806 ). I like the idea to make z-Up an option in the exporter, as described by #12784, but until now the rotation was just plain wrong, unfortunately. There are probably additional issues when it comes to lights and cameras being exported, but this PR at least makes mesh rotation be exported correctly.

Use correct rotation for static objects when exporting scenes
@mrdoob
Copy link
Owner

mrdoob commented Jan 4, 2018

I don't think this really fixes it...

test_scene.blend.zip

screen shot 2018-01-03 at 4 27 52 pm

Before your fix:

screen shot 2018-01-03 at 4 28 07 pm

After your fix:

screen shot 2018-01-03 at 4 28 17 pm

@mrdoob
Copy link
Owner

mrdoob commented Jan 4, 2018

It is better, but the monkey looks away from the torus.

@mrdoob
Copy link
Owner

mrdoob commented Jan 4, 2018

We could investigate how export_yup works in the glTF-Blender-Exporter:
https://github.com/KhronosGroup/glTF-Blender-Exporter/blob/master/scripts/addons/io_scene_gltf2/__init__.py#L171

They are getting the right output:

screen shot 2018-01-03 at 4 37 15 pm

@BenCidPerez
Copy link
Contributor Author

Yep sorry, it looked fine in my test scene. Right now different export options give you vastly differing results, when it comes to rotation and the exporter code is rather opaque when it comes to finding out where which rotations are actually being applied.

@Mugen87
Copy link
Collaborator

Mugen87 commented Jan 9, 2018

Also see #12903

@Mugen87
Copy link
Collaborator

Mugen87 commented May 31, 2018

The JSON Blender exporter has been removed with R93 (#14117).

@Mugen87 Mugen87 closed this May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants