SpriteNodeMaterial: Set `transparent=true` as default #30435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

sunag merged 1 commit into mrdoob:dev from sunag:dev-transparent

Jan 31, 2025

Collaborator

sunag commented Jan 31, 2025

Related issue: #30433 (comment)

Description

Set transparent=true as default in sprites.


          SpriteNodeMaterial: Set transparent=true as default

757bae4

sunag added this to the r174 milestone

github-actions bot commented Jan 31, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

	Before	After	Diff
WebGL	336.27 78.29	336.27 78.29	+0 B +0 B
WebGPU	517.06 143.53	517.08 143.61	+20 B +79 B
WebGPU Nodes	516.52 143.42	516.54 143.5	+20 B +77 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

	Before	After	Diff
WebGL	465.25 112.13	465.25 112.13	+0 B +0 B
WebGPU	589.07 159.69	589.09 159.7	+20 B +6 B
WebGPU Nodes	544.45 149.25	544.45 149.25	+0 B +0 B

sunag marked this pull request as ready for review

January 31, 2025 16:20

sunag merged commit 8a475a6 into mrdoob:dev

12 checks passed

sunag deleted the dev-transparent branch

January 31, 2025 16:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet