Skip to content

Conversation

zonkypop
Copy link
Contributor

@zonkypop zonkypop commented Feb 25, 2025

Issue
Shader compile errors when using uint/int Data3DTexture on the new WebGLBackend due to incorrect uniform types being declared.

Description
Currently in the GLSLNodeBuilder, all Data3DTextures are being declared as sampler3D. This PR adds the same checks which DataTexture have for their type, so usampler3D and isampler3D are now declared for their respective types

Copy link

github-actions bot commented Feb 25, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.64
78.39
336.64
78.39
+0 B
+0 B
WebGPU 522.6
145.08
522.64
145.1
+39 B
+20 B
WebGPU Nodes 522.07
144.98
522.11
145
+39 B
+19 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.76
112.28
465.76
112.28
+0 B
+0 B
WebGPU 593.07
160.7
593.11
160.72
+39 B
+18 B
WebGPU Nodes 548.19
150.13
548.23
150.16
+39 B
+20 B

@Mugen87 Mugen87 added this to the r174 milestone Feb 27, 2025
@Mugen87 Mugen87 merged commit fcc8bd6 into mrdoob:dev Feb 27, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants