Skip to content

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Feb 27, 2025

Related issue: -

Description

In earlier days members of classes were sometimes added in methods but not in the constructor which means they could ended up as undefined.

It is easier to follow the code if members are always defined in the constructor and get proper default values.

@Mugen87 Mugen87 added this to the r175 milestone Feb 27, 2025
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.16
78.31
336.64
78.39
+486 B
+82 B
WebGPU 522.64
145.1
522.64
145.1
+0 B
+0 B
WebGPU Nodes 522.11
145
522.11
145
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.27
112.2
465.76
112.28
+489 B
+80 B
WebGPU 593.11
160.72
593.11
160.72
+0 B
+0 B
WebGPU Nodes 548.23
150.16
548.23
150.16
+0 B
+0 B

@Mugen87 Mugen87 merged commit 791353c into mrdoob:dev Feb 27, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant