IFFParser: Fix missing Debbuger attribute declarations #30946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With this PR,
|
s-rigaud
force-pushed
the
iffparser-debugger-add-default-attribute-values
branch
from
e92a793 to
2261bb3
Compare
|
My bad, rebase went wrong |
|
Do you mind removing |
s-rigaud
force-pushed
the
iffparser-debugger-add-default-attribute-values
branch
from
2261bb3 to
54328c4
Compare
RuthySheffi
pushed a commit
to RuthySheffi/three.js
that referenced
this pull request
Jun 5, 2025
Co-authored-by: Samuel Rigaud <[email protected]>
RuthySheffi
pushed a commit
to RuthySheffi/three.js
that referenced
this pull request
Jun 5, 2025
Co-authored-by: Samuel Rigaud <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Debugger missing attribute declarations. Also got rid of old
varkeywords.