Skip to content

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Jul 26, 2025

Closes #31478

Description

Double-check on the parents of the atomic functions to prevent errors and improve error message for do not use atomic in vertex or fragment stages. https://webgpu.rocks/wgsl/functions/synchronization-atomic/

Copy link

github-actions bot commented Jul 26, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 338.37
78.9
338.37
78.9
+0 B
+0 B
WebGPU 561.4
155.29
561.53
155.34
+128 B
+47 B
WebGPU Nodes 560.01
155.05
560.14
155.1
+128 B
+48 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 469.75
113.6
469.75
113.6
+0 B
+0 B
WebGPU 636.14
172.14
636.26
172.19
+117 B
+46 B
WebGPU Nodes 590.79
161.38
590.91
161.42
+117 B
+46 B

@sunag sunag marked this pull request as ready for review July 26, 2025 03:57
@sunag sunag merged commit 206a138 into mrdoob:dev Jul 26, 2025
9 checks passed
@sunag sunag deleted the dev-parents-fix branch July 26, 2025 03:58
@Mugen87 Mugen87 added this to the r179 milestone Jul 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to add atomic op inside vertex node
2 participants