XRManager: Fix typo in getBinding jsdoc #31656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Mugen87 merged 1 commit into mrdoob:dev from vincentfretin:patch-2

Aug 15, 2025

Contributor

vincentfretin commented Aug 15, 2025

Fix getBinding jsdoc in XRManager to be the same as the one in WebXRManager, that was missed in the review of #31648


          XRManager: Fix typo in getBinding jsdoc

259d242

github-actions bot commented Aug 15, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

	Before	After	Diff
WebGL	338.96 79.12	338.96 79.12	+0 B +0 B
WebGPU	575.35 158.76	575.35 158.76	+0 B +0 B
WebGPU Nodes	573.96 158.51	573.96 158.51	+0 B +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

	Before	After	Diff
WebGL	470.7 113.89	470.7 113.89	+0 B +0 B
WebGPU	646.42 174.83	646.42 174.83	+0 B +0 B
WebGPU Nodes	600.6 164.01	600.6 164.01	+0 B +0 B

Mugen87 added this to the r180 milestone

Mugen87 merged commit d8a9927 into mrdoob:dev

9 checks passed

vincentfretin deleted the patch-2 branch

August 15, 2025 10:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet