Skip to content

Docs: fix null params #31742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 25, 2025
Merged

Docs: fix null params #31742

merged 2 commits into from
Aug 25, 2025

Conversation

s-rigaud
Copy link
Contributor

Use ? annotation everywhere for consistency, add missing null annotations and I re-run build-docs and everything seems ok.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 25, 2025 •
edited
Loading

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 338.91
79.11		 338.91
79.11		 +0 B
+0 B
WebGPU 578.16
159.25		 578.16
159.25		 +0 B
+0 B
WebGPU Nodes 576.76
159.01		 576.76
159.01		 +0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 470.78
113.9		 470.78
113.9		 +0 B
+0 B
WebGPU 648.69
175.28		 648.69
175.28		 +0 B
+0 B
WebGPU Nodes 602.79
164.41		 602.79
164.41		 +0 B
+0 B

Mugen87
Mugen87 reviewed Aug 25, 2025
View reviewed changes
@Mugen87 Mugen87 added this to the r180 milestone Aug 25, 2025
@Mugen87 Mugen87 merged commit d47d1d8 into mrdoob:dev Aug 25, 2025
9 checks passed
@s-rigaud s-rigaud deleted the docs-fix-null branch September 4, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r180
Development

Successfully merging this pull request may close these issues.
2 participants
@s-rigaud @Mugen87