Types: fix missing properties #31772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
reviewed
Aug 28, 2025
Mugen87
reviewed
Aug 28, 2025
s-rigaud
force-pushed
the
fix-missing-types
branch
from
b4ff3eb to
bda8084
Compare
s-rigaud
force-pushed
the
fix-missing-types
branch
from
bda8084 to
2f86f39
Compare
Mugen87
reviewed
Aug 29, 2025
Revert changes to `getHelperFromSkeleton()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing these errors:
ConstantsInterpolationSamplingMode - FIRST EITHER type ref
examples/jsm/utils/SkeletonUtils.js - error TS2339: Property 'skeleton' does not exist on type 'SkeletonHelper'.
examples/jsm/loaders/lwo/IFFParser.js - error TS2339: Property 'littleEndian' does not exist on type 'DataViewReader'.