Inconsistent behavior with escaped single quotes & brace expansion

[Oasiris]

Environment

• OS Version
  1. MacOS Ventura 13.4.1 (Apple Silicon)
  2. Windows 10
• Node.js Version: 22.7.0
• fast-glob: 3.3.2

Actual behavior

On MacOS and Windows, escaping single quotes will cause some globs that otherwise fail (return no results) to succeed, but cause other globs that would otherwise succeed to fail.

Expected behavior

• Either the tests with escaped single quotes should return results, or the tests with unescaped single quotes should return results.

Steps to reproduce

• See linked PR with tests: Add failing tests for incorrect handling of single quotes w/ brace expansion #479

---

Code sample

For this directory structure:

# Setup
mkdir fourth
touch "fourth/file'sA.md" 
touch "fourth/file'sB.md"
mkdir "fifth's"
touch "fifth's/fileA.md" 
touch "fifth's/fileB.md" 

The following test is picky about single quotes being escaped:

require("fast-glob").sync("fourth/file's{A,B}.md")
// => []
require("fast-glob").sync("fourth/file\\'s{A,B}.md")
// => ["fourth/file'sA.md", "fourth/file'sB.md"]

The following test is picky about single quotes being UN-escaped:

require("fast-glob").sync("fifth's/file*.md")
// => ["fifth's/fileA.md", "fifth's/fileB.md"]
require("fast-glob").sync("fifth\\'s/file*.md")
// => []

The following test fails regardless of whether the quote is escaped or not:

require("fast-glob").sync("fifth's/file{A,B}.md")
// => []
require("fast-glob").sync("fifth\\'s/file{A,B}.md")
// => []

[Oasiris]

In upstream dependencies micromatch@4.0.8 and braces@3.0.3, all tests with escaped single quotes pass:

// micromatch@4.0.8
require('micromatch').match(["fourth/file'sA.md", "fourth/file'sB.md"], "fourth/file\\'s{A,B}.md")
// [ "fourth/file'sA.md", "fourth/file'sB.md" ]

require('micromatch').match(["fifth's/fileA.md", "fifth's/fileB.md"], "fifth\\'s/file*.md")
// [ "fifth's/fileA.md", "fifth's/fileB.md" ]

require('micromatch').match(["fifth's/fileA.md", "fifth's/fileB.md"], "fifth\\'s/file{A,B}.md")
// [ "fifth's/fileA.md", "fifth's/fileB.md" ]


// braces@3.0.3
require('braces')("fourth/file\\'s{A,B}.md", { expand: true })
// [ "fourth/file'sA.md", "fourth/file'sB.md" ]

require('braces')("fifth\\'s/file{A,B}.md", { expand: true })
// [ "fifth's/fileA.md", "fifth's/fileB.md" ]

Reproduced test results on Windows 10.

[mrmlnc]

Thanks for the detailed description of the problem!

There are several problems here.

---

require("fast-glob").sync("fourth/file's{A,B}.md")
// => []
require("fast-glob").sync("fourth/file\\'s{A,B}.md")
// => ["fourth/file'sA.md", "fourth/file'sB.md"]

// Also

require("fast-glob").sync("fifth's/file{A,B}.md")
// => []
require("fast-glob").sync("fifth\\'s/file{A,B}.md")
// => []

This is happening because quotes may also be used as an alternative to backslashes for escaping. The braces package removes quotes by default.

The other solutions like wcmatch (python) and node-glob (js) do not follow this logic.

---

The following behavior is correct because the pattern is used without changes. The fifth's is a directory on file system.

require("fast-glob").sync("fifth's/file*.md")
// => ["fifth's/fileA.md", "fifth's/fileB.md"]

This behavior is incorrect, because the base directory for the pattern should be . (because the pattern has an escape symbol), and not fifth\\'s, as it is happening now. Ideally, escaping quotes for base directory should be removed at the pattern parsing stage.

require("fast-glob").sync("fifth\\'s/file*.md")
// => []

[mrmlnc]

There are two fixes here:

1. ISSUE-56: correctly handle an unpaired quotes micromatch/braces#57
2. ISSUE-480: remove backslashes from the pattern's base directory #481

[Oasiris]

This is awesome @mrmlnc , prompt and thorough. Thanks!