revert(android): revert change AndroidManifest to support RN < 0.71 #561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mrousavy Hi, i create new PR for revert AndroidManifest change. Sorry about prev PR, when i sync code from master, something wrong so my change was discarded |
|
Hey thanks for your PR man! |
|
@mrousavy what block you to make a npm release? |
|
Hey mrousavy, mean that if app have react-native version 0.64.0 it should be work so I can upgrade to latest version of mkkv ? @mrousavy |
|
@mrousavy Confused by how this should work below RN < 0.71 as version Release 2.6.0 min support level is 0.71+. What version can be used with 0.69 #407? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR revert AndroidManifest file to add support RN 0.71