Skip to content

Make nested struct pointers work #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 22, 2018

Conversation

msabramo
Copy link

@msabramo msabramo commented Jan 17, 2018

Great work on google#99 !

I hope this helps you to get it merged!

Cc: @shwoodard

@msabramo
Copy link
Author

I’ll add a test in a little bit

@msabramo msabramo force-pushed the pr-99-make-nested-struct-ptr-work branch from c70fb9e to 16e19ab Compare January 17, 2018 21:02
@msabramo
Copy link
Author

OK, I added a test in b28beab. If I checkout that commit without 16e19ab, then the result is:

$ go test ./
--- FAIL: TestUnmarshalNestedStructPtr (0.00s)
	request_test.go:981: Pointer type in struct is not supported
FAIL
FAIL	_/Users/abramowi/dev/git-repos/jsonapi	0.013s

With 16e19ab, the result is:

$ go test ./
ok  	_/Users/abramowi/dev/git-repos/jsonapi	0.020s

@mrowdy
Copy link
Owner

mrowdy commented Jan 22, 2018

Ha! Amazingly simple. Thx @msabramo for adding this

@mrowdy mrowdy merged commit 21b4945 into mrowdy:master Jan 22, 2018
@msabramo msabramo deleted the pr-99-make-nested-struct-ptr-work branch January 23, 2018 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants