-
Notifications
You must be signed in to change notification settings - Fork 11
fix(coverde-cli): proper file deletions #221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes incorrect usage of the recursive parameter with File.deleteSync(). In Dart, the deleteSync() method for File objects does not accept a recursive parameter (only Directory.deleteSync() does), so removing this parameter corrects the API usage.
- Removed invalid
recursive: trueparameter fromFile.deleteSync()calls in production code - Updated CHANGELOG to document the fix
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/coverde_cli/lib/src/commands/rm/rm.dart | Fixed file deletion by removing invalid recursive parameter |
| packages/coverde_cli/lib/src/commands/optimize_tests/optimize_tests.dart | Fixed file deletion by removing invalid recursive parameter |
| packages/coverde_cli/CHANGELOG.md | Added changelog entry for the file deletion fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #221 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Details
Perform proper file deletion