Skip to content

Conversation

@mrverdant13
Copy link
Owner

Details

Perform proper file deletion

@mrverdant13 mrverdant13 requested a review from Copilot November 26, 2025 22:37
@mrverdant13 mrverdant13 self-assigned this Nov 26, 2025
@mrverdant13 mrverdant13 added bug Something isn't working fix p:coverde Related to the 'coverde' package labels Nov 26, 2025
Copilot finished reviewing on behalf of mrverdant13 November 26, 2025 22:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes incorrect usage of the recursive parameter with File.deleteSync(). In Dart, the deleteSync() method for File objects does not accept a recursive parameter (only Directory.deleteSync() does), so removing this parameter corrects the API usage.

  • Removed invalid recursive: true parameter from File.deleteSync() calls in production code
  • Updated CHANGELOG to document the fix

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
packages/coverde_cli/lib/src/commands/rm/rm.dart Fixed file deletion by removing invalid recursive parameter
packages/coverde_cli/lib/src/commands/optimize_tests/optimize_tests.dart Fixed file deletion by removing invalid recursive parameter
packages/coverde_cli/CHANGELOG.md Added changelog entry for the file deletion fix

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mrverdant13 mrverdant13 merged commit d605be5 into main Nov 26, 2025
12 checks passed
@mrverdant13 mrverdant13 deleted the coverde-cli/fix/file-deletions branch November 26, 2025 22:49
@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (57ed08e) to head (cb49878).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #221   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working fix p:coverde Related to the 'coverde' package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants