Replace defensive Rf_error() with ASSERT() in impl code

These guards are unreachable when exported wrappers validate correctly.
ASSERT() is active in debug builds and compiles to nothing in release.

Author: ms609

src/day_1985.cpp

@@ -3,6 +3,8 @@ using namespace Rcpp;
 
 #include "tree_distances.h" /* includes <TreeTools/SplitList.h> */
 #include "information.h"
+#include <cassert>
+#include <TreeTools/assert.h>
 
 #include <TreeTools.h> /* for root_on_node() */
 #include <TreeTools/root_tree.h> /* for root_on_node() */
@@ -96,7 +98,7 @@ double calc_consensus_info(const List &trees, const LogicalVector &phylo,
 
   std::vector<ClusterTable> tables;
   if (std::size_t(n_trees) > tables.max_size()) {
-    Rf_error("Not enough memory available to compute consensus of so many trees"); // LCOV_EXCL_LINE
+    ASSERT(false && "Not enough memory for consensus of so many trees"); // LCOV_EXCL_LINE
   }
 
   tables.reserve(n_trees);

src/hpart.cpp

@@ -126,7 +126,7 @@ size_t build_node_from_list(const RObject& node,
   if (Rf_isInteger(node) || Rf_isReal(node)) {
     const IntegerVector leaf_vec(node);
     if (leaf_vec.size() != 1) {
-      Rf_error("List must only contain integers, not vectors of integers");   // #nocov
+      ASSERT(false && "List must only contain integers, not vectors of integers"); // #nocov
     }
     const int leaf_label = leaf_vec[0];         // 1-based R leaf label
     const size_t leaf_idx = leaf_label - 1;     // 0-based label for HNode
@@ -172,7 +172,7 @@ size_t build_node_from_list(const RObject& node,
   }
 
   // Invalid node type
-  Rf_error("Invalid node type");                                              // #nocov
+  ASSERT(false && "Invalid node type");                                        // #nocov
 }
 
 

src/hpart_relabel.cpp

@@ -13,7 +13,7 @@ void recompute_bitsets_postorder(TreeDist::HPart &hpart, const size_t node_idx,
   if (node.children.empty()) {
     // Leaf node
     if (node.leaf_count != 1) {
-      Rf_error("Leaf node has leaf_count != 1");                              // #nocov
+      ASSERT(node.leaf_count == 1 && "Leaf node has leaf_count != 1");         // #nocov
     }
     int new_index = mapping[node.label]; // mapping is 0-based
     node.label = new_index;

src/information.h

@@ -2,7 +2,7 @@
 #define _TREEDIST_INFO_H
 
 #include <Rcpp/Lightest>
-#include <cassert> /* for log2() */
+#include <TreeTools/assert.h>
 #include <cmath> /* for log2() */
 #include "ints.h" /* for int16 */
 
@@ -48,14 +48,12 @@ __attribute__((constructor))
 
 inline double split_phylo_info(const int32 n_in, const int32 *n_tip,
                                const double p) {
-  if (*n_tip > CT_MAX_LEAVES) {
-    Rf_error("This many leaves are not yet supported.");
-  }
+  ASSERT(*n_tip <= CT_MAX_LEAVES && "This many leaves are not yet supported.");
   const int32 n_out = *n_tip - n_in;
-  assert(p > 0);
-  assert(p <= 1);
-  assert(n_in > 1);
-  assert(n_out > 1);
+  ASSERT(p > 0);
+  ASSERT(p <= 1);
+  ASSERT(n_in > 1);
+  ASSERT(n_out > 1);
   if (p == 1) {
     return (l2unrooted[*n_tip] - l2rooted[n_in] - l2rooted[n_out]);
   } else {
@@ -74,14 +72,12 @@ inline double split_phylo_info(const int32 n_in, const int32 *n_tip,
 
 inline double split_clust_info(const int32 n_in, const int32 *n_tip,
                                const double p) {
-  if (*n_tip > CT_MAX_LEAVES) {
-    Rf_error("This many leaves are not yet supported.");
-  }
+  ASSERT(*n_tip <= CT_MAX_LEAVES && "This many leaves are not yet supported.");
   const int32 n_out = *n_tip - n_in;
-  assert(p > 0);
-  assert(p <= 1);
-  assert(n_in > 1);
-  assert(n_out > 1);
+  ASSERT(p > 0);
+  ASSERT(p <= 1);
+  ASSERT(n_in > 1);
+  ASSERT(n_out > 1);
   return -p * (
       (((n_in * l2[n_in]) + (n_out * l2[n_out])) / *n_tip) - l2[*n_tip]
   );

src/spr.cpp

@@ -119,7 +119,7 @@ IntegerVector confusion(const RawMatrix& x, const RawMatrix& y) {
 
 IntegerMatrix reverse (const IntegerMatrix x) {
   if (double(x.nrow()) > double(std::numeric_limits<intx>::max())) {
-    Rf_error("This many edges are not (yet) supported."); // impl guard; wrapper validates
+    ASSERT(false && "This many edges are not (yet) supported."); // wrapper validates
   }
   const intx n_edge = intx(x.nrow());
   ASSERT(n_edge % 2 == 0); // Tree is binary