Fix msvc build #295
Merged
Fix msvc build #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @proller , thank you for sending the PR. It works well. It seems that msgpack_vc.postbuild.bat is empty. I think that it is better to remove postbuild process from msgpack_vc8.vcproj. What do you think? By the way, windows build for msgpack-c has been moved to cmake. |
Contributor
Author
|
I think every empty file can be removed. |
Contributor
|
Ok. I removed post-build files and settings. I also find a missing include path setting in DEBUG build, and fixed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.