Support vectors of non-default-constructible values in c++11 mode #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for sending the PR. |
Contributor
|
Implemented container's support except boost. It includes SFINAE checking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently was added support for non-default-constructible classes using as.
But there should be the similar functionality for containers of such values.
I've just created initial version for vector, but it is not final patch I am expecting to be merged into msgpack. There must be support for other container types (e.g. map) and proper std::enable_if checks.
I do not feel comfortable to create full patch, but expect that Takatoshi Kondo or other maintainers will create polished patch. This is just suggested idea.