Add CI testing of signed/unsigned char differences #398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should help catch problems like msgpack#392 sooner. Signed-off-by: James McCoy <[email protected]>
jamessan
force-pushed
the
unsigned-char-ci
branch
from
5530717 to
71eba24
Compare
Contributor
Author
|
Updated to set CXXFLAGS, and now Travis is failing as expected. |
Contributor
|
@jamessan, thank you for sending the PR. It's very helpful :) |
redboltz
added a commit
that referenced
this pull request
Jan 13, 2016
Add CI testing of signed/unsigned char differences
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help catch problems like #392 sooner.