Check whether MSGPACK_ENDIAN_LITTLE_BYTE is true, not defined. #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msgpack/predef/other/endian.h always defines both MSGPACK_ENDIAN_LITTLE_BYTE and MSGPACK_ENDIAN_BIG_BYTE, but they're defined to a true or false value depending on whether the system is little/big endian. Fix this condition to check the truthiness rather than whether it is defined, like the other locations this macro is checked. Closes msgpack#403 Signed-off-by: James McCoy <[email protected]>
Contributor
|
@jamessan, thank you very much! |
redboltz
added a commit
that referenced
this pull request
Jan 15, 2016
Check whether MSGPACK_ENDIAN_LITTLE_BYTE is true, not defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
msgpack/predef/other/endian.h always defines both
MSGPACK_ENDIAN_LITTLE_BYTE and MSGPACK_ENDIAN_BIG_BYTE, but they're
defined to a true or false value depending on whether the system is
little/big endian.
Fix this condition to check the truthiness rather than whether it is
defined, like the other locations this macro is checked.
Closes #403
Signed-off-by: James McCoy [email protected]