Skip to content

Conversation

@ibell
Copy link
Contributor

@ibell ibell commented Feb 14, 2016

This is important because the integer definitions clash with the integer definitions in the rapidjson C++ library, but only at the level of signed/unsigned integers. We use both libraries in the CoolProp library

@redboltz
Copy link
Contributor

@ibell, thank you for sending the PR. I will merge it.

Before merging, I'd like to confirm a point. I think that the actual problem is only happened __int8. Because it is a typedef of char, and char, singed char, and unsigned char are different types. See https://msdn.microsoft.com/en-US/library/s3f49ktz(v=vs.90).aspx
However, other types without signed keyword such as __int16 are equivalent to signed types, in this case it is a typedef of signed short int.

The PR added all types to singed for a uniformity.

Am I understanding correctly?

@ibell
Copy link
Contributor Author

ibell commented Feb 14, 2016

I know that the problems happen for me with int8_t, and I figured it made sense to fix them all. And yes, it seems pretty much only for VS9 where I have problems. Other versions of MSVC work fine.

redboltz added a commit that referenced this pull request Feb 14, 2016
Add signed flags to MSVC integer definitions
@redboltz redboltz merged commit 988f72d into msgpack:master Feb 14, 2016
@redboltz
Copy link
Contributor

Thank you for the clarification :) merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants