Fixed #422. #426
Merged
Fixed #422. #426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced the inheriting constructor with a forwarding constructor. Removed the template constructors that are covered by the forwarding constructor. Added std::forward() to make_tuple. Added conversion constructor. Moved msgpack::type::tuple to include/msgpack/v1/adaptor/detail/cpp11_msgpack_tuple_decl.hpp from include/msgpack/v1/adaptor/detail/cpp11_msgpack_tuple.hpp. msgpack::type::tuple_cat requires the class template tuple definition.
redboltz
added a commit
that referenced
this pull request
Feb 20, 2016
redboltz
added a commit
to redboltz/msgpack-c
that referenced
this pull request
Feb 20, 2016
redboltz
added a commit
that referenced
this pull request
Feb 20, 2016
Backported #426 to version 1.4.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the inheriting constructor with a forwarding constructor.
Removed the template constructors that are covered by the forwarding constructor.
Added std::forward() to make_tuple.
Added conversion constructor.
Moved msgpack::type::tuple to
include/msgpack/v1/adaptor/detail/cpp11_msgpack_tuple_decl.hpp from
include/msgpack/v1/adaptor/detail/cpp11_msgpack_tuple.hpp.
msgpack::type::tuple_cat requires the class template tuple definition.