Skip to content

Conversation

@aberaud
Copy link
Contributor

@aberaud aberaud commented Jun 7, 2016

Hi,
Just noticed Autotools and MSVC support was dropped.
We use cmake already on Linux and OSX so dropping Autotools is fine for us,
but MSVC is still useful and needed to build natively on Windows.

It makes sense to drop autotools, but I don't see the point to remove native MSVC support.

@redboltz
Copy link
Contributor

redboltz commented Jun 9, 2016

@aberaud , I commented #469 (comment)
msgpack_vc8.sln and msgpack_vc8.vcproj are replaced by cmake.

@redboltz
Copy link
Contributor

@aberaud, I will close the PR if you have no comments.

@aberaud
Copy link
Contributor Author

aberaud commented Jun 19, 2016

@redboltz
Thanks for your reply,
We use msgpack in a complex project and apparently cmake generated projects have some issues.
Could you consider having native project files back ? It's not that big

@redboltz
Copy link
Contributor

@aberaud

We use msgpack in a complex project and apparently cmake generated projects have some issues.

If you have a problem using cmake with MSVC, please report the issue. We are ready to solve the problem.

Could you consider having native project files back ? It's not that big

Ok, I understand your situation, so I merge the PR :)

However, it is out of out support. It is for VS 2008, pretty old. MS provide upgrade mechanism to up to date version of MSVC, so far. However, there is no guaranty providing the mechanism in the future.

I recommend to migrate cmake.

Anyway I merge the PR.

@redboltz redboltz merged commit 438c4ff into msgpack:master Jun 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants